cluster-proportional-autoscaler icon indicating copy to clipboard operation
cluster-proportional-autoscaler copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Support custom `priorityClassName` in the helm chart

Open chotiwat opened this issue 2 years ago • 4 comments

This will allow us to use the Helm chart for things like CoreDNS autoscaler.

This PR also bumps the chart version and app version (may conflict with #126).

chotiwat avatar Aug 29 '22 22:08 chotiwat

Welcome @chotiwat!

It looks like this is your first PR to kubernetes-sigs/cluster-proportional-autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-proportional-autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 29 '22 22:08 k8s-ci-robot

/assign @bowei

chotiwat avatar Aug 29 '22 22:08 chotiwat

Any update on this @bowei @krmichel?

chotiwat avatar Oct 14 '22 23:10 chotiwat

/lgtm

krmichel avatar Oct 17 '22 12:10 krmichel

@krmichel: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 17 '22 12:10 k8s-ci-robot

@MrHohn Sorry I missed this. I don't have the ability to mark this lgtm, but I did add an approval

krmichel avatar Oct 17 '22 14:10 krmichel

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chotiwat, krmichel, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 17 '22 17:10 k8s-ci-robot

Thanks all!

chotiwat avatar Oct 17 '22 20:10 chotiwat

@MrHohn I am not sure why but the helm chart release failed. Can you try running that workflow again? I tried it on my fork and it seemed to work

krmichel avatar Oct 17 '22 21:10 krmichel

@krmichel Sure thing, looks like just a flake - triggered a re-run and it passes this time.

MrHohn avatar Oct 17 '22 21:10 MrHohn