kubernetes-sigs
:sparkles: Add topology field for Strategy
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5145
Hi @farodin91. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
~@neolit123 I think it's fair to do this in two parts:~ ~1) Expose the rollout strategy in topology (this PR)~ ~2) Add additional strategies to cover advanced use cases.~
~This allows on-delete to be used which at least allows an external service to do MD-by-MD updates. I think we might need a new issue for additional strategies, especially if they involve lifecycle hooks etc. @randomvariable WDYT?~
I misread the original issue. @farodin91 could you remove that issue from this PR as this is a different use case (but still a very welcome improvement!) I'll get to reviewing this today :slightly_smiling_face:
I dropped the issue from the PR description to avoid closing the issue accidentally
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment