cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

📖 update cert-manager label searching command

Open charlie-haley opened this issue 3 years ago • 4 comments

What this PR does / why we need it: kubectl get all -A doesn't actually return all resources, see https://github.com/kubernetes/kubectl/issues/151. This command should now cover all the CAPI mangaed cert-manager resources.

charlie-haley avatar Oct 07 '22 08:10 charlie-haley

Hi @charlie-haley. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 07 '22 08:10 k8s-ci-robot

/ok-to-test

oscr avatar Oct 07 '22 08:10 oscr

Nice find!

/lgtm

oscr avatar Oct 07 '22 08:10 oscr

Thank you for fixing this!

/lgtm

oscr avatar Oct 31 '22 14:10 oscr

Thank you very much!

/approve

sbueringer avatar Oct 31 '22 14:10 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 31 '22 14:10 k8s-ci-robot