cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

[release-1.2] :book: Update docs/Makefile. Fix proposal diagrams transparency

Open oscr opened this issue 3 years ago • 8 comments

What this PR does / why we need it:

Adds 3 pr's that updates the CAPI book and proposals diagrams and the Makefile.

oscr avatar Aug 10 '22 18:08 oscr

@oscr: This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 10 '22 18:08 k8s-ci-robot

I also included #7017 to keep the build working. With it make diagrams doesn't produce a diff.

oscr avatar Aug 11 '22 09:08 oscr

@ykakarap I updated the pr description to reflect the changes as you mentioned. Anything you would like to add?

oscr avatar Aug 11 '22 09:08 oscr

One thing 🙂 /retitle [release-1.2] Update docs/Makefile. Fix proposal diagrams transparency

killianmuldoon avatar Aug 11 '22 10:08 killianmuldoon

That just brings the title into line with how we tend to do other cherry-picks

killianmuldoon avatar Aug 11 '22 10:08 killianmuldoon

One thing 🙂 /retitle [release-1.2] :book: Update docs/Makefile. Fix proposal diagrams transparency

killianmuldoon avatar Aug 11 '22 10:08 killianmuldoon

Is there a reason why we can't cherry-pick the individual PRs in the right order? It would save us the work of re-reviewing all changes and would keep it a lot simpler tracking-wise

sbueringer avatar Aug 16 '22 12:08 sbueringer

The reason was a merge conflict when cherry-picking #7046. I also added #7017 to ensure that if you run make diagrams and get the new diagrams.

oscr avatar Aug 17 '22 07:08 oscr

Sounds good.

We should cherry-pick #7056 after #7050 is merged

sbueringer avatar Aug 17 '22 11:08 sbueringer

Diffed against main. Everything identical apart from #7056

/lgtm /approve

sbueringer avatar Aug 17 '22 11:08 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 17 '22 11:08 k8s-ci-robot