cluster-api 🌱 Improve logging for the MachineSet scale up/down workflow

🌱 Improve logging for the MachineSet scale up/down workflow

Open fabriziopandini opened this issue 3 years ago • 2 comments

What this PR does / why we need it: Make logs for the MachineSet scale up/down workflow consistent with the new logging guidelines

Which issue(s) this PR fixes: Rif https://github.com/kubernetes-sigs/cluster-api/issues/6994

Aug 05 '22 13:08 fabriziopandini

/triage accepted

Aug 05 '22 13:08 fabriziopandini

@sbueringer all the comments should be addressed now, PTAL at your convenience

Sep 02 '22 12:09 fabriziopandini

@sbueringer comments addressed; changes are in a separated commit for a faster review

Sep 02 '22 15:09 fabriziopandini

Thx!

/approve

lgtm pending squash :)

Sep 02 '22 17:09 sbueringer

/approve cancel

Hm maybe let's not approve already, not that it gets accidentally merged before squash :)

Sep 02 '22 17:09 sbueringer

@sbueringer squashed

Sep 06 '22 07:09 fabriziopandini

Thx!

/lgtm /approve

Sep 06 '22 10:09 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Sep 06 '22 10:09 k8s-ci-robot