cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🌱 Fix empty control-plane taints example
What this PR does / why we need it:
The docs to remove the default control plane taints instruct the user to set the value to an empty slice, i.e. taints: {} in the YAML file , but an empty slice is equal to an empty yaml array: taints: [].
Which issue(s) this PR fixes: Fixes #
@apricote: This issue is currently awaiting triage.
If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
We should IMO only make this change in v1beta1 as v1alpha4 is no longer directly supported.
Should we clean up (remove) some of those files? Or is there a reason to keep them around?
Should we clean up (remove) some of those files? Or is there a reason to keep them around?
My understanding is we have to keep those API versions around as long as we support upgrading from an older API version to the current one. I think we're not due to drop support until we drop support for Kubernetes 1.22 (if I'm reading the table right), but it might be dropped sooner or later depending on the community.
@stmcginnis @killianmuldoon The reason why we currently keep the apiVersions is because while we don't support v1alpha3 CAPI versions anymore we might still want to support upgrading from v1alpha3 to a supported version.
Also in my opinion we have to fix the following issue first before we can drop apiVersions: https://github.com/kubernetes-sigs/cluster-api/issues/5470 Otherwise clusters initially created with v1alpha3 will just break.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment