cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🌱 Update Cluster API Visualizer chart to v1.0.0
What this PR does / why we need it: Update Cluster API Visualizer chart to v1.0.0
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
@Jont828: This issue is currently awaiting triage.
If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@CecileRobertMichon What do you think about trying to implement some functionality to automatically keep this up to date with the latest image version? One idea is to change the tilt-prepare logic to always fetch the latest version of the chart. Another idea is to pin the version to latest and override the default appVersion.
@Jont828 What do you think about dropping the first commit and merging the second one?
I think they don't depend on each other and I would like to use the new version of the visualizer without having to change my source files :)
Sure I'm happy to merge this first. The reason I rebased it off of the Makefile PR is because people probably won't be able to see the update on the chart until they run make clean-charts and there's nothing documented currently to show that they won't get the update automatically
Makes sense. Let's go ahead anyway. At least folks following the PRs are aware
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment