cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

✨ Add generic addon deployment config to tilt

Open killianmuldoon opened this issue 3 years ago • 3 comments

Signed-off-by: killianmuldoon [email protected]

Add a generic deployment mechanism for addons to the tilt file and tilt prepare. This mechanism allows Runtime SDK extensions to be developed alongside the core controllers using the Tilt development flow. It can also be used to develop arbitrary deployments and addons built using the same workflow in tilt as providers use today.

May be related to #6647 /area runtime-sdk Fixes #6864

killianmuldoon avatar Jul 28 '22 16:07 killianmuldoon

lgtm we have only to sort out merge order with 6483 that could help us in keeping the tiltfile simple and clean and overcome current limitation that prevents us from having different env variables for each customize call

fabriziopandini avatar Aug 03 '22 22:08 fabriziopandini

:+1 Let's merge 6483 first. I'll rebase this on that PR.

killianmuldoon avatar Aug 04 '22 09:08 killianmuldoon

/hold remove

Underlying PR is now merged.

killianmuldoon avatar Aug 23 '22 11:08 killianmuldoon

/lgtm /approve

Looks great! We'll address the open findings in a follow-up PR.

sbueringer avatar Aug 29 '22 17:08 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 29 '22 17:08 k8s-ci-robot

/hold cancel

Wrong command at https://github.com/kubernetes-sigs/cluster-api/pull/6991#issuecomment-1223933492 :slightly_smiling_face:

killianmuldoon avatar Aug 29 '22 20:08 killianmuldoon