cluster-api
cluster-api copied to clipboard
✨ Add generic addon deployment config to tilt
Signed-off-by: killianmuldoon [email protected]
Add a generic deployment mechanism for addons to the tilt file and tilt prepare. This mechanism allows Runtime SDK extensions to be developed alongside the core controllers using the Tilt development flow. It can also be used to develop arbitrary deployments and addons built using the same workflow in tilt as providers use today.
May be related to #6647 /area runtime-sdk Fixes #6864
lgtm we have only to sort out merge order with 6483 that could help us in keeping the tiltfile simple and clean and overcome current limitation that prevents us from having different env variables for each customize call
:+1 Let's merge 6483 first. I'll rebase this on that PR.
/hold remove
Underlying PR is now merged.
/lgtm /approve
Looks great! We'll address the open findings in a follow-up PR.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold cancel
Wrong command at https://github.com/kubernetes-sigs/cluster-api/pull/6991#issuecomment-1223933492 :slightly_smiling_face: