cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

✨ MHC to mark CP machines as unhealthy when certificates are about to expire

Open ykakarap opened this issue 3 years ago • 3 comments

What this PR does / why we need it:

This PR add MachineHealthCheck support to make controlplane machines whose certificate are not valid for more than a min duration specified as unhealthy which trigger a rollout.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #6529

ykakarap avatar Jul 26 '22 16:07 ykakarap

/retitle ✨ [WIP] Automatically renew control plane machine certificates before expiration through machine repave

ykakarap avatar Sep 02 '22 20:09 ykakarap

Reviewed the delta, looks good so far. Once we finalized the API and the PR is otherwise ready I would do some in-depth manual testing and another detailed review

sbueringer avatar Sep 06 '22 13:09 sbueringer

This looks pretty good!

Only nits, except (potentially) https://github.com/kubernetes-sigs/cluster-api/pull/6983#discussion_r968486156

sbueringer avatar Sep 12 '22 14:09 sbueringer

Great work!

lgtm pending squash

sbueringer avatar Sep 14 '22 08:09 sbueringer

Squashed.

ykakarap avatar Sep 14 '22 15:09 ykakarap

Thx!

/lgtm

sbueringer avatar Sep 14 '22 15:09 sbueringer

lgtm pending squash

sbueringer avatar Sep 16 '22 06:09 sbueringer

Squashed.

ykakarap avatar Sep 16 '22 23:09 ykakarap

great job! this is a long-awaited feature for many CAPI users /lgtm

fabriziopandini avatar Sep 19 '22 08:09 fabriziopandini

Great work!

/approve

Would be good to surface this feature somewhere in our book

sbueringer avatar Sep 19 '22 09:09 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 19 '22 09:09 k8s-ci-robot

Would be good to surface this feature somewhere in our book

@ykakarap do you mind opening an issue for this?

fabriziopandini avatar Sep 19 '22 10:09 fabriziopandini

Would be good to surface this feature somewhere in our book

@ykakarap do you mind opening an issue for this?

Issue: https://github.com/kubernetes-sigs/cluster-api/issues/7247

ykakarap avatar Sep 20 '22 02:09 ykakarap