cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

ClusterClass make MachineDeployment NodeDeletionTimeout configurable via Cluster topology

Open sbueringer opened this issue 2 years ago • 13 comments

User Story

As a user I would like to configure the NodeDeletionTimeout of a MachineDeployment.

Details

Prior art for this is the addition of nodeDrainTimeout in #6278.

PR: https://github.com/kubernetes-sigs/cluster-api/pull/6379 Detailed description on what to do: https://github.com/kubernetes-sigs/cluster-api/issues/6278#issuecomment-1070914169 (of course only the NodeDeletionTimeout parts are relevant)

/kind feature /area topology

sbueringer avatar Apr 27 '22 14:04 sbueringer

/good-first-issue

sbueringer avatar Apr 27 '22 14:04 sbueringer

@sbueringer: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 27 '22 14:04 k8s-ci-robot

/milestone v1.2

fabriziopandini avatar Apr 28 '22 09:04 fabriziopandini

/assign

palnabarun avatar May 01 '22 12:05 palnabarun

Is there any progress on this issue?

24sama avatar Jun 09 '22 08:06 24sama

@palnabarun Do you have time to work on this?

sbueringer avatar Jun 23 '22 09:06 sbueringer

/assign

abhijit-dev82 avatar Jul 21 '22 07:07 abhijit-dev82

@sbueringer I can start working on this. Is that ok?

abhijit-dev82 avatar Jul 22 '22 06:07 abhijit-dev82

@abhijit-dev82 let's wait until the person already assigned to it responds. @palnabarun have you been able to make any progress so far, or are you happy to hand this off?

killianmuldoon avatar Jul 22 '22 10:07 killianmuldoon

/triage accepted /assign @killianmuldoon

fabriziopandini avatar Jul 29 '22 17:07 fabriziopandini

/unassign @palnabarun @abhijit-dev82 feel free to start working on this issue

fabriziopandini avatar Jul 29 '22 17:07 fabriziopandini

@abhijit-dev82 Just to check in - are you still interested in working on this issue?

killianmuldoon avatar Aug 04 '22 14:08 killianmuldoon

@killianmuldoon Yes, got busy with some other work, will get some diffs out soon.

abhijit-dev82 avatar Aug 04 '22 15:08 abhijit-dev82