cluster-api
cluster-api copied to clipboard
kubernetes-sigs
Add support for RolloutAfter to MachineDeployments
We have had good feedback about KCP's upgradeAfter field (now being renamed to rolloutAfter). It'd be great to add the same functionality to MachineDeployments.
/kind feature /milestone v0.4 /help
@vincepri: This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
We have had good feedback about KCP's upgradeAfter field (now being renamed to rolloutAfter). It'd be great to add the same functionality to MachineDeployments.
/kind feature /milestone v0.4 /help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
FYI This issue is somehow related https://github.com/kubernetes-sigs/cluster-api/issues/4450
An interesting nuance is that there is demand for both RolloutAfter Instant in Time and for RolloutAfter Time Interval.
Wondering how we can model this...
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale
@vincepri PR is in good shape but given the timelines and the lack of feedback/testing in real use I think we should probably punt on this until we release v1beta1. Let me know if you think otherwise. /milestone next
@enxebre: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.
In response to this:
@vincepri PR is in good shape but given the timelines and the lack of feedback/testing in real use I think we should probably punt on this until we release v1beta1. Let me know if you think otherwise. /milestone next
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@enxebre: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.
In response to this:
/milestone v1.1
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I assume this is still valid to get implemented to also proceed at #5218 (which was triaged as accepted and this one is required).
@enxebre are you still working on this or would you be ok if I recycle your implementation to file a new PR?
Still a valid feature, we should be looking at rollout as a larger feature as well
@chrischdi I'm not actively working on implementing this, please go for it.
@sbueringer: Closing this issue.
In response to this:
/close
Done in #8216
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.