cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

Add support for returning warnings to user as part of validation webhook

Open invidian opened this issue 4 years ago • 12 comments

User Story

As a user I would like to see the warnings in my configuration for ability to fix them.

Detailed Description As a follow up to #4172, parsed Ignition configuration may contain some warnings and it would be good to inform user about them. Right now, we have no functionality to do that.

More details here: https://github.com/kubernetes-sigs/cluster-api/pull/4172#discussion_r584669828

/kind feature

invidian avatar Mar 09 '21 11:03 invidian

/milestone v0.4.0 /area bootstrap

fabriziopandini avatar Mar 09 '21 13:03 fabriziopandini

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jun 07 '21 14:06 fejta-bot

/remove-lifecycle stale

invidian avatar Jun 07 '21 14:06 invidian

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 05 '21 14:09 k8s-triage-robot

Not stale.

invidian avatar Sep 05 '21 17:09 invidian

/remove-lifecycle stale

IMO this should be implemented in controller runtime first, but I still have to research the topic a little bit more

fabriziopandini avatar Sep 06 '21 12:09 fabriziopandini

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 20 '22 17:01 k8s-triage-robot

/remove-lifecycle stale

invidian avatar Jan 20 '22 17:01 invidian

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 04 '22 19:05 k8s-triage-robot

/remove-lifecycle stale

invidian avatar May 04 '22 21:05 invidian

Depends on CR issues:

  • https://github.com/kubernetes-sigs/controller-runtime/issues/1896
  • https://github.com/kubernetes-sigs/controller-runtime/issues/1788

sbueringer avatar May 10 '22 14:05 sbueringer

/triage accepted

this is being worked on controller runtime

fabriziopandini avatar Oct 03 '22 17:10 fabriziopandini

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 01 '23 17:01 k8s-triage-robot

/remove-lifecycle stale

invidian avatar Jan 02 '23 09:01 invidian

@invidian can we close this now the cr PRs are merged?

enxebre avatar Jun 30 '23 12:06 enxebre

Sounds good. I created #8944 as a follow up to actually start using those warnings functionality.

invidian avatar Jun 30 '23 12:06 invidian