cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard
verified publisher icon kubernetes-sigs

Add conditions to MachineDeployment Object

Open Arvinderpal opened this issue 5 years ago • 30 comments

User Story As a developer/user/operator I would like to have conditions documenting the operational state of MachineDeployment objects.

Anything else you would like to add: As required by the condition CAEP, the MachineDeployment objects should also provide a Ready condition describing the overall state of the object.

Tasks:

  • [x] Summary ReadyCondition and Node availability condition AvailableCondition https://github.com/kubernetes-sigs/cluster-api/pull/4625
  • [x] MachineSet related conditions: MachinesCreatedCondition, MachinesReadyCondition and ResizedCondition https://github.com/kubernetes-sigs/cluster-api/pull/5056
  • [ ] MachineDeployment scaling related conditions: MachinesSpecUpToDateCondition and ResizedCondition
  • [ ] Remove the use of Phases
  • [ ] Cleanup: Change calculateStatus() --> updateStatus() to be consistent with the rest of the code base.

Related: Conditions for KCP

/kind feature

Arvinderpal avatar Aug 14 '20 13:08 Arvinderpal

Ideally, we would have something similar to DeploymentProgressing.

This is more to bring in line with how kubectl rollout status works. With clusterctl rollout status my-md-0 we would also watch the progression of the MD by looking at MachinesReadyCondition. I think that would accomplish something similar.

Arvinderpal avatar Aug 14 '20 13:08 Arvinderpal

/cc @fabriziopandini

Arvinderpal avatar Aug 14 '20 13:08 Arvinderpal

/milestone v0.4.0

vincepri avatar Aug 20 '20 17:08 vincepri

/milestone v0.4.0

vincepri avatar Sep 02 '20 16:09 vincepri

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Dec 01 '20 17:12 fejta-bot

/remove-lifecycle stale

detiber avatar Dec 01 '20 18:12 detiber

Can I be assigned this ticket? Not that anyone else is jumping to work on it :laughing: I'll need this for the clusterctl rollout status command: https://github.com/kubernetes-sigs/cluster-api/issues/3439

Arvinderpal avatar Feb 08 '21 19:02 Arvinderpal

@Arvinderpal Sure, feel free to take it!

/priority important-soon /assign @Arvinderpal

vincepri avatar Feb 08 '21 20:02 vincepri

@vincepri @detiber I have the PR ready. PTAL https://github.com/kubernetes-sigs/cluster-api/pull/4174

Arvinderpal avatar Feb 13 '21 22:02 Arvinderpal

/lifecycle active

fabriziopandini avatar Feb 15 '21 11:02 fabriziopandini

/kind release-blocking

CecileRobertMichon avatar Apr 05 '21 20:04 CecileRobertMichon

@fabriziopandini to check if the PR is ready to go and double check the release blocking status

vincepri avatar Apr 28 '21 17:04 vincepri

/area api

enxebre avatar Sep 16 '21 10:09 enxebre

/milestone v1.0

vincepri avatar Oct 19 '21 14:10 vincepri

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 20 '22 19:01 k8s-triage-robot

/remove-lifecycle stale

fabriziopandini avatar Jan 20 '22 19:01 fabriziopandini

For MachineDeployments it'd be interesting to consider signal as conditions and differentiate rolling upgrades e.g

  • Upgrading Version.
  • Upgrading because of bootstrap provider change.
  • Upgrading because of an infra change.

Thoughts?

enxebre avatar Feb 03 '22 12:02 enxebre

/milestone v1.2

enxebre avatar Feb 03 '22 12:02 enxebre

@enxebre More granular info would be great. Are you suggesting a new condition for each of those bullets? Would they be better captured in the Reason/Message of a single condition? I'm leaning towards the latter.

Arvinderpal avatar Feb 03 '22 14:02 Arvinderpal

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 04 '22 14:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 03 '22 14:06 k8s-triage-robot

/lifecycle frozen

fabriziopandini avatar Jun 05 '22 10:06 fabriziopandini

/triage accepted

fabriziopandini avatar Sep 30 '22 19:09 fabriziopandini

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Feb 08 '23 01:02 k8s-triage-robot

/triage accepted

fabriziopandini avatar Mar 21 '23 09:03 fabriziopandini

/remove-priority important-soon /priority backlog

fabriziopandini avatar Mar 21 '23 09:03 fabriziopandini

/help

fabriziopandini avatar Mar 21 '23 09:03 fabriziopandini

@fabriziopandini: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 21 '23 09:03 k8s-ci-robot

cc @muraee

enxebre avatar Jun 16 '23 12:06 enxebre

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jun 15 '24 12:06 k8s-triage-robot