cluster-api
cluster-api copied to clipboard
kubernetes-sigs
Rename references to "node-role.kubernetes.io/master"
See upstream Kubeadm issue https://github.com/kubernetes/kubeadm/issues/2200
/kind cleanup /wg naming /milestone Next
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/milestone v1.1
Ref: https://grep.app/search?current=2&q=node-role.kubernetes.io/master&filter[repo][0]=kubernetes-sigs/cluster-api
/assign @randomvariable @sbueringer
The new labels were only applied in v1.20 onwards and v1.19 is still on the support matrix for mgmt clusters. In this case, for now, we should add the additional toleration, as per https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/config/manager/manager.yaml#L40-L44
@randomvariable: This request has been marked as suitable for new contributors.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/help /good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi, I want to take this up and I will assign it to myself because no one else seems to be assigned. Thanks and please let me know if any issues.
@avirekghatia thanks for volonteering. please sync up with the kubeadm efforts as well. Please also note, that in CAPI we support a wide range of Kubernetes versions, so it is required to find out a solution that works with both old and new labels
@fabriziopandini I think it would be good to get this implemented before the release because of the changes in kubeadm 1.24: https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/XJhn8bpvHac
I think we also might have to do something about the label:
in 1.24 we are adding a new taint "node-role.kubernetes.io/control-plane" with effect "NoSchedule" and removing the "node-role.kubernetes.io/master" label on nodes
It might even should be release blocking.
WIP PR for 1.24 (stage 2) is here: https://github.com/kubernetes/kubernetes/pull/107533
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
If I understand it correctly with Kubernetes 1.25 the old master taint will be dropped. The old label was dropped with 1.24.
This means for us:
- when the minimum supported Kubernetes version is v1.24 we can drop any special handling for the old label
- when the minimum supported Kubernetes version is v1.25 we can drop any special handling for the old taint
Until then
/lifecycle frozen
To post this here as well as I regularly have to look this up somewhere:
Labels:
- -v1.19: only the old label is set
- v1.20-v1.23: both labels are set
- v1.24+: only the new label is set
Taints:
- -v1.23: only old taint is set
- v1.24: both taints are set
- v1.25+: only new taint is set
If I understand it correctly with Kubernetes 1.25 the old master taint will be dropped. The old label was dropped with 1.24.
This means for us:
- when the minimum supported Kubernetes version is v1.24 we can drop any special handling for the old label
- when the minimum supported Kubernetes version is v1.25 we can drop any special handling for the old taint
Until then
/lifecycle frozen
Related: https://github.com/kubernetes-sigs/cluster-api/issues/8040 (with a policy we eventually get to "when the minimum supported Kubernetes version is v1.24/v1.25"
@sbueringer: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.