kubernetes-sigs
[WIP][POC] ✨ Remove CR dependency in API packages
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This PR is currently missing an area label, which is used to identify the modified component when generating release notes.
Area labels can be added by org members by writing /area ${COMPONENT} in a comment
Please see the labels list for possible areas.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@sbueringer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-test-main | cefa7d91619f1ab529ba7cf323d4e127d83c22f1 | link | true | /test pull-cluster-api-test-main |
| pull-cluster-api-build-main | cefa7d91619f1ab529ba7cf323d4e127d83c22f1 | link | true | /test pull-cluster-api-build-main |
| pull-cluster-api-verify-main | cefa7d91619f1ab529ba7cf323d4e127d83c22f1 | link | true | /test pull-cluster-api-verify-main |
| pull-cluster-api-apidiff-main | cefa7d91619f1ab529ba7cf323d4e127d83c22f1 | link | false | /test pull-cluster-api-apidiff-main |
| pull-cluster-api-e2e-blocking-main | cefa7d91619f1ab529ba7cf323d4e127d83c22f1 | link | true | /test pull-cluster-api-e2e-blocking-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
so in short are we aiming to refactor conversion logic to make zz_* generated files more generic across the project (which would solve etcd issues mentioned such as old object vs new object in the KV store) especially if we're talking external apis - does it relate to https://github.com/kubernetes-sigs/controller-runtime/pull/3335?
And real qeustion is going to be how to properly convert Changed Resource Versions issues for external apis since there is not straight forward of doing this due to the state, so it seems as the effort for modularization in a form of submodules. Would be nice to avoid creation these kind of PRs manually as they affect tests mostly quite often being simply not synchronized with latest changes - internal vs external conversion should, imo, stay separate which, correct if wrong, this is being progressively achieved.
I'd look at tests deeper to make sure they are properly adopted since quite of a logic was moved but I agree 100 that addons should be separate for the user.
