cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

Consider blocking ClusterClass rebase between CCs with and without a CP machineInfrastructure

Open sbueringer opened this issue 8 months ago • 5 comments

ClusterClassesAreCompatible currently only checks compatitbility of both current & desired MachineInfrastructures are defined

xref: https://github.com/kubernetes-sigs/cluster-api/pull/12545#discussion_r2244922062

cc @fabriziopandini

sbueringer avatar Jul 31 '25 12:07 sbueringer

/triage accepted /kind feature /area clusterclass /priority backlog

sbueringer avatar Jul 31 '25 12:07 sbueringer

Makes sense, +1 from me enforcing that rebase can happen only after the topology is created

fabriziopandini avatar Aug 01 '25 06:08 fabriziopandini

enforcing that rebase can happen only after the topology is created

What does this have to do with this issue? :)

sbueringer avatar Aug 01 '25 07:08 sbueringer

Before topology is created, in theory we don't care if we transition from something with or without CP infrastructure. (but it is also perfectly fine to ignore this edge case, creating a topology is usually quick) /help

fabriziopandini avatar Sep 17 '25 13:09 fabriziopandini

@fabriziopandini: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

Before topology is created, in theory we don't care if we transition from something with or without CP infrastructure. (but it is also perfectly fine to ignore this edge case, creating a topology is usually quick) /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 17 '25 13:09 k8s-ci-robot