cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

⚠️ Add initialization status and failure domain to Machine and Cluster status to satisfy v2contract

Open sivchari opened this issue 5 months ago • 9 comments

What this PR does / why we need it:

Part of #11947

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

sivchari avatar Jun 26 '25 07:06 sivchari

/cc @sbueringer @fabriziopandini

sivchari avatar Jun 26 '25 10:06 sivchari

I addressed all reviews. Please review again.

sivchari avatar Jun 26 '25 12:06 sivchari

/retest

sivchari avatar Jun 27 '25 01:06 sivchari

/area provider/infrastructure-docker

sivchari avatar Jun 27 '25 03:06 sivchari

/test pull-cluster-api-e2e-main

sbueringer avatar Jun 27 '25 05:06 sbueringer

I'm ok for the implementation, but I assume that we have to invest a little bit on investigating the test failures + let's have a look on the entire test suite /test pull-cluster-api-e2e-conformance-ci-latest-main /test pull-cluster-api-e2e-conformance-main /test pull-cluster-api-e2e-latestk8s-main /test pull-cluster-api-e2e-main /test pull-cluster-api-e2e-mink8s-main /test pull-cluster-api-e2e-upgrade-1-33-1-34-main

fabriziopandini avatar Jun 27 '25 08:06 fabriziopandini

@sivchari Please trigger all the tests (https://github.com/kubernetes-sigs/cluster-api/pull/12409#issuecomment-3012218582) once the findings are resolved

sbueringer avatar Jun 27 '25 17:06 sbueringer

/retest

sivchari avatar Jun 29 '25 13:06 sivchari

/test pull-cluster-api-e2e-conformance-ci-latest-main /test pull-cluster-api-e2e-conformance-main /test pull-cluster-api-e2e-latestk8s-main /test pull-cluster-api-e2e-main /test pull-cluster-api-e2e-mink8s-main /test pull-cluster-api-e2e-upgrade-1-33-1-34-main

sivchari avatar Jun 29 '25 14:06 sivchari

/test pull-cluster-api-e2e-conformance-ci-latest-main /test pull-cluster-api-e2e-conformance-main /test pull-cluster-api-e2e-latestk8s-main /test pull-cluster-api-e2e-main /test pull-cluster-api-e2e-mink8s-main /test pull-cluster-api-e2e-upgrade-1-33-1-34-main

sivchari avatar Jun 30 '25 04:06 sivchari

/cc @sbueringer @fabriziopandini

sivchari avatar Jun 30 '25 07:06 sivchari

@sivchari Thx! Last minor findings from my side

sbueringer avatar Jun 30 '25 08:06 sbueringer

Thank you very much!

/test pull-cluster-api-e2e-conformance-ci-latest-main /test pull-cluster-api-e2e-conformance-main /test pull-cluster-api-e2e-latestk8s-main /test pull-cluster-api-e2e-main /test pull-cluster-api-e2e-mink8s-main /test pull-cluster-api-e2e-upgrade-1-33-1-34-main

/lgtm

sbueringer avatar Jun 30 '25 09:06 sbueringer

LGTM label has been added.

Git tree hash: db1ddbc448d5311a65203a9cec2bccdcb2ea6908

k8s-ci-robot avatar Jun 30 '25 09:06 k8s-ci-robot

/approve

fabriziopandini avatar Jun 30 '25 09:06 fabriziopandini

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 30 '25 09:06 k8s-ci-robot