cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

Update github.com/olekukonko/tablewriter to v1+

Open JoelSpeed opened this issue 7 months ago • 6 comments

CAPI is currently using the v0.0.5 version of github.com/olekukonko/tablewriter.

However, there are now new v1 versions, at time of writing, v1.0.7 is the latest.

There are breaking changes between the pre-v1 and v1 versions of the dependency, and some manual attention will be required to update the dependency.

Dependabot PRs (https://github.com/kubernetes-sigs/cluster-api/pull/12313#issuecomment-2936380113) sadly won't be sufficient.

ToDo:

  • Identify usage of the tablewriter dependency
  • Update to the latest version
  • Ensure updated function names/functionality are updated where used

JoelSpeed avatar Jun 04 '25 09:06 JoelSpeed

/label help-wanted

JoelSpeed avatar Jun 04 '25 09:06 JoelSpeed

@JoelSpeed: The label(s) /label help-wanted cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 04 '25 09:06 k8s-ci-robot

/triage accepted /help /priority important-longterm

JoelSpeed avatar Jun 04 '25 09:06 JoelSpeed

@JoelSpeed: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/triage accepted /help /priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 04 '25 09:06 k8s-ci-robot

/kind cleanup

JoelSpeed avatar Jun 04 '25 09:06 JoelSpeed

I will take care of it. /assign

Karthik-K-N avatar Jun 04 '25 12:06 Karthik-K-N

/unassign /assign @irapandey

Karthik-K-N avatar Sep 17 '25 06:09 Karthik-K-N

@Karthik-K-N: GitHub didn't allow me to assign the following users: irapandey.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/unassign /assign @irapandey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 17 '25 06:09 k8s-ci-robot

/assign

irapandey avatar Sep 17 '25 07:09 irapandey