cluster-api
cluster-api copied to clipboard
kubernetes-sigs
✨ migrate Requeue to RequeueAfter
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12272
This PR is currently missing an area label, which is used to identify the modified component when generating release notes.
Area labels can be added by org members by writing /area ${COMPONENT} in a comment
Please see the labels list for possible areas.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/assign
I don't know when I'll get around to it, but I want to review this PR before it's merged
Will try to get back to this once we're done with v1beta2 for this release
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@sivchari
Can we split this up in separate PRs? One PR after another per reconciler would be good.
Some of these changes are non-trivial (as we have to access the impact on the reconcile behavior case by case) and breaking this down into smaller PRs makes it more realistic that we find enough time for reviews (and don't have to rebase too often)
@sivchari: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.