cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🌱 clusterctl: add nutanix ipam & runtime extensions providers
- :seedling: clusterctl: add nutanix ipam provider
- :seedling: clusterctl: add nutanix runtime extensions provider
@elmiko @JoelSpeed if you have time for review 🙏 should be pretty quick and easy hopefully.
I'm fine with allowing to use simply "nutanix" given that the same org already owns the "nutanix" infra provider. @fabriziopandini Do you agree?
@jimmidyson Is this the only thing blocking this PR (apart from rebase + the nit above)?
@sbueringer Yes this is now ready to go! Tested locally and all working perfectly!
I'm fine with allowing to use simply "nutanix" given that the same org already owns the "nutanix" infra provider. @fabriziopandini Do you agree?
commented above
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Feel free to cherry-pick into release-1.8 if you want (might require a manual cherry-pick)
@jimmidyson: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.
In response to this:
/cherrypick release-1.8
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jimmidyson: #11135 failed to apply on top of branch "release-1.8":
Applying: seedling: clusterctl: add nutanix ipam provider
Using index info to reconstruct a base tree...
M cmd/clusterctl/client/config/providers_client.go
M cmd/clusterctl/client/config_test.go
M cmd/clusterctl/cmd/config_repositories_test.go
A docs/book/src/developer/providers/contracts/clusterctl.md
M docs/book/src/reference/glossary.md
M docs/book/src/reference/providers.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/reference/providers.md
Auto-merging docs/book/src/reference/glossary.md
Auto-merging docs/book/src/clusterctl/provider-contract.md
Auto-merging cmd/clusterctl/cmd/config_repositories_test.go
CONFLICT (content): Merge conflict in cmd/clusterctl/cmd/config_repositories_test.go
Auto-merging cmd/clusterctl/client/config_test.go
Auto-merging cmd/clusterctl/client/config/providers_client.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 seedling: clusterctl: add nutanix ipam provider
In response to this:
/cherrypick release-1.8
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Manual backport in https://github.com/kubernetes-sigs/cluster-api/pull/11414