Feature: ClusterResourceSet

[sbueringer]

• CAEP: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20200220-cluster-resource-set.md
• Feature gate state:
  • [x] Alpha (disabled per default): v0.3
  • [x] Beta (enabled per default): v0.4
  • [ ] Stable (feature GA): TBD
  • [ ] Feature gate removed 1 release later: TBD

[fabriziopandini]

+1 to graduate if we all agree / make it clear in the documentation/API (if not already) the intended scope of this feature:

it provides a basic solution for installing & managing resources, while for advanced use cases an addon provider must be used.

[mcbenjemaa]

I would be interested in taking this issue,

APART from the documentation, what else is needed to remove the feature gate and make it part of CAPI by default?

[fabriziopandini]

Note for discussion:

• Graduation means to update the feature flag as described above
• Code organisation should be aligned by moving stuff out from experimental (it can also happen at a different time)

[sbueringer]

/help

[k8s-ci-robot]

@sbueringer: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mcbenjemaa]

/assign

[fabriziopandini]

WRT to "Integrate CRS code into regular code structure":

• content of exp/addons/controllers/alias.go must be moved to controllers/alias.go; then the exp/addons/controllers folder must be deleted (corresponding import must be fixed; same for all the other steps)
• folder exp/addons/internal/controllers must be moved to internal/controllers and renamed to clusterresourceset
• content of exp/addons/webhooks/alias.go must be moved to webhooks/alias.go; then the exp/addons/webhooks folder must be deleted
• content of the folder exp/addons/internal/webhooks must be moved to internal/webhooks; then the exp/addons/internal folder must be deleted
• exp/addons/api/v1beta1/*.tyeps.go must be copied to api/v1beta1/addons
• folder exp/addons must be deleted
• content of internal/apis/core/exp/addons/v1alpha* must be merged with internal/apis/core/v1alpha*

[fabriziopandini]

@mcbenjemaa do you want to take over also ^^ (this would be really appreciated)

[mcbenjemaa]

For sure)

[sbueringer]

@mcbenjemaa Do you have time to work on it? Ideally we would like to get this done for the upcoming minor release

[mcbenjemaa]

I will start it soon.

[mcbenjemaa]

I'm just struggling with the generation right now.

@fabriziopandini regarding:

content of internal/apis/core/exp/addons/v1beta* must be merged with internal/apis/core/v1beta*

There is no v1beta* there but v1alpha*. Was that a mistake?

[fabriziopandini]

There is no v1beta* there but v1alpha*. Was that a mistake

Sorry, my bad. Fixed

[vincepri]

Left a comment on the related issue, it seems the PR is moving these types into the core, while they were into a different group. https://github.com/kubernetes-sigs/cluster-api/pull/11943/files#r1986213854

[sbueringer]

I'll answer on the PR. I think you're right and the instructions above are not entirely correct.

[fabriziopandini]

Fixed the instructions above

[mcbenjemaa]

/reopen

[k8s-ci-robot]

@mcbenjemaa: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.