🌱 Added go directive test

[AvineshTripathi]

fixes #10258

[AvineshTripathi]

/retest

[fabriziopandini]

thanks for picking up this task! lgtm pending fixing the shell-check error

[AvineshTripathi]

/retest

[AvineshTripathi]

@sbueringer am not sure if my changes are breaking stuff could you confirm

[fabriziopandini]

/test pull-cluster-api-test-main

This seems a flake (there is also a discussion thread in slack)

[fabriziopandini]

/area ci

[fabriziopandini]

@AvineshTripathi thanks for working on this! /lgtm cc @sbueringer @killianmuldoon for a final pass (otherwise I will merge in a few days)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: fe36be89b3c3b477151bc76d50197697b088c8ed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/lgtm

/hold cancel

[sbueringer]

Would be great if we can manual cherry-pick this PR into 1.6 & 1.5 (in both cases we should use 1.20 as GO_DIRECTIVE_VERSION)

@AvineshTripathi Do you want to take this over?

[AvineshTripathi]

Hey sure I can take those up, can you explain bit more "manual cherry-pick this pr into.."

[sbueringer]

Basically you create the same PR against the release-1.6 & release-1.5 branch (but using 1.20 as GO_DIRECTIVE_VERSION). You can either do it entirely manually or something like this:

git checkout release-1.6
git checkout -b release-1.6-go-directive
git cherry-pick <commit of this PR>
# Change GO_DIRECTIVE_VERSION  to 1.20
git commit --amend
...

Just saying "Manually" because usually we have a cherry-pick bot. But this won't be enough as we want to use 1.20