cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

🌱 WIP: Add MachinePools to autoscaler e2e test

Open willie-yao opened this issue 1 year ago • 6 comments

What this PR does / why we need it: This PR adds MachinePools to the autoscaler e2e tests. This is a follow-up task to enabling MachinePools in ClusterClass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes part of #10028

/area clusterclass

willie-yao avatar Jan 31 '24 23:01 willie-yao

/test ?

willie-yao avatar Jan 31 '24 23:01 willie-yao

@willie-yao: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-29-1-30-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 31 '24 23:01 k8s-ci-robot

@sbueringer Figured out the issues and this should now be ready for review! I'm wondering if there's a more efficient way to test both MD and MP in this flow right now though... I'm having to remove the annotations and delete the previous scale up deployment to test MPs without unpredictable behavior from the autoscaler.

willie-yao avatar Mar 26 '24 22:03 willie-yao

/test pull-cluster-api-e2e-main

willie-yao avatar Mar 27 '24 00:03 willie-yao

/test pull-cluster-api-e2e-main

Running a few times to ensure the test isn't flaky.

willie-yao avatar Apr 03 '24 20:04 willie-yao

LGTM label has been added.

Git tree hash: b441bbf4d3fddd063e7b8644e64a77ff6e5ced01

k8s-ci-robot avatar Apr 04 '24 10:04 k8s-ci-robot

/test pull-cluster-api-e2e-main

Edit: unrelated flake, rerunning

willie-yao avatar Apr 04 '24 16:04 willie-yao

/test pull-cluster-api-e2e-main

willie-yao avatar Apr 04 '24 20:04 willie-yao

/test pull-cluster-api-e2e-main

sbueringer avatar Apr 05 '24 05:04 sbueringer

/test pull-cluster-api-e2e-main

willie-yao avatar Apr 05 '24 21:04 willie-yao

Really nice work!

Thank you very much!

/lgtm /approve

sbueringer avatar Apr 08 '24 17:04 sbueringer

LGTM label has been added.

Git tree hash: 0b80e69805e1a1d79e176c10636f8d3c18da6436

k8s-ci-robot avatar Apr 08 '24 17:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 08 '24 17:04 k8s-ci-robot