cluster-api
cluster-api copied to clipboard
🌱 WIP: Add MachinePools to autoscaler e2e test
What this PR does / why we need it: This PR adds MachinePools to the autoscaler e2e tests. This is a follow-up task to enabling MachinePools in ClusterClass.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):
Fixes part of #10028
/area clusterclass
/test ?
@willie-yao: The following commands are available to trigger required jobs:
-
/test pull-cluster-api-build-main
-
/test pull-cluster-api-e2e-blocking-main
-
/test pull-cluster-api-e2e-conformance-ci-latest-main
-
/test pull-cluster-api-e2e-conformance-main
-
/test pull-cluster-api-e2e-dualstack-and-ipv6-main
-
/test pull-cluster-api-e2e-main
-
/test pull-cluster-api-e2e-mink8s-main
-
/test pull-cluster-api-e2e-upgrade-1-29-1-30-main
-
/test pull-cluster-api-test-main
-
/test pull-cluster-api-test-mink8s-main
-
/test pull-cluster-api-verify-main
The following commands are available to trigger optional jobs:
-
/test pull-cluster-api-apidiff-main
Use /test all
to run the following jobs that were automatically triggered:
-
pull-cluster-api-apidiff-main
-
pull-cluster-api-build-main
-
pull-cluster-api-e2e-blocking-main
-
pull-cluster-api-test-main
-
pull-cluster-api-verify-main
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@sbueringer Figured out the issues and this should now be ready for review! I'm wondering if there's a more efficient way to test both MD and MP in this flow right now though... I'm having to remove the annotations and delete the previous scale up deployment to test MPs without unpredictable behavior from the autoscaler.
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main
Running a few times to ensure the test isn't flaky.
LGTM label has been added.
/test pull-cluster-api-e2e-main
Edit: unrelated flake, rerunning
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main
Really nice work!
Thank you very much!
/lgtm /approve
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment