cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
kubernetes-sigs
Disable auto-approve for PRs
/kind feature
Describe the solution you'd like Disable auto-approval of PRs. Currently when an individual with approver status submits a PR, the PR is automatically approved. This results in a lot of explicit holds since we try to prevent drive-by lgtms from merging a PR before it's deemed ready.
@andrewsykim and I think disabling auto-approve will reduce the need for explicit holds in many to perhaps even most cases. We also want to be clear, approving your own PR shouldn't necessarily be frowned upon as it's the current behavior as auto-approve is enabled. However, this change would at least make the approval an explicit action.
cc @sidharthsurana @ncdc @codenrhoden @yastij Thoughts?
/assign @andrewsykim
I don't have approver status in this repo, but in other repos where I do have it, I've generally not been a fan of auto-approve. I was surprised it is the default.
So I would be +1 for this, but it's definitely up to the OWNERS here. :)
+1 from me. It's disabled in https://github.com/kubernetes/cloud-provider-vsphere and I prefer it over holding PRs all the time.
I also have no issue with this. @andrewsykim, can you please go ahead and file a PR while we wait to see if any other feedback is received? Thanks!
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten
Unsure if this warrants any change right now. Is everyone in favor of closing this?
As far as I can tell this is disabled now (looking at recent PRs)
/close
@sbueringer: Closing this issue.
In response to this:
As far as I can tell this is disabled now (looking at recent PRs)
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
