cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

🌱 flavorgen: Bump CSI to v3.3.0

Open chrischdi opened this issue 1 year ago • 13 comments
trafficstars

What this PR does / why we need it:

Bumps vsphere CSI to v3.3.0

  • CSI now works with SHA256 thumbprints

xref: #2519

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

chrischdi avatar Jul 03 '24 07:07 chrischdi

no /cherry-pick release-1.10

chrischdi avatar Jul 03 '24 07:07 chrischdi

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/hold maybe we should have a check for failing pods

chrischdi avatar Jul 03 '24 08:07 chrischdi

Thx!

/lgtm /approve

sbueringer avatar Jul 04 '24 14:07 sbueringer

LGTM label has been added.

Git tree hash: 39a163a6bc1b149210ad1f5ad5d909f0e9f2d0f0

k8s-ci-robot avatar Jul 04 '24 14:07 k8s-ci-robot

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

sbueringer avatar Jul 04 '24 14:07 sbueringer

@chrischdi The other PR is merged, I guess we can merge once the tests are green (aka already remove the hold?)

sbueringer avatar Jul 04 '24 14:07 sbueringer

We should disable insecure for CSI on this PR to ensure it stays green. I'll make the change.

chrischdi avatar Jul 04 '24 14:07 chrischdi

Let's see if this gets green.

chrischdi avatar Jul 04 '24 14:07 chrischdi

/hold

To merge #3024 first

chrischdi avatar Jul 04 '24 15:07 chrischdi

Otherwise lgtm so far

sbueringer avatar Jul 04 '24 15:07 sbueringer

/hold cancel /test help

chrischdi avatar Jul 05 '24 12:07 chrischdi

@chrischdi: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main
  • /test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/hold cancel /test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 05 '24 12:07 k8s-ci-robot

/test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main

chrischdi avatar Jul 05 '24 12:07 chrischdi

Thx!

/lgtm /approve

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

sbueringer avatar Jul 05 '24 13:07 sbueringer

LGTM label has been added.

Git tree hash: 6098e169778f1375bd8511835272b2d60d5f7e46

k8s-ci-robot avatar Jul 05 '24 13:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 05 '24 13:07 k8s-ci-robot