cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
kubernetes-sigs
🌱 Fill up supervisor e2e test - clusterctl upgrades using ClusterClass
What this PR does / why we need it:
- Enable test "When testing clusterctl upgrades using ClusterClass"
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2995
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
Test result indicated there's no CRD of AvailabilityZone, but I think this PR didn't touch AvailabilityZone or VMOperatorDependencies. Retry it...
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
[FAILED] Failed to reconcile VMOperatorDependencies
Unexpected error:
<*errors.withStack | 0xc000620810>:
failed to get AvailabilityZone cluster-1: no matches for kind "AvailabilityZone" in version "topology.tanzu.vmware.com/v1alpha1"
{
error: <*errors.withMessage | 0xc000bab300>{
cause: <*meta.NoKindMatchError | 0xc0011cc0c0>{
GroupKind: {
Group: "topology.tanzu.vmware.com",
Kind: "AvailabilityZone",
},
SearchedVersions: ["v1alpha1"],
},
msg: "failed to get AvailabilityZone cluster-1",
},
stack: [0x243e45b, 0xea9f32, 0xea9d87, 0xeaa238, 0x2438676, 0x249acfc, 0x228e8c7, 0xbac733, 0xbc07cd, 0x4741c1],
}
occurred
In [It] at: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-vsphere/test/e2e/e2e_setup_test.go:310 @ 05/27/24 06:11:19.972
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
Looks like the test failed due to missing StorageClass CRD, I didn't find out who's responsible for creating it. @chrischdi would you please help to take a look, thanks!
[38;5;9m[FAILED] Failed to reconcile VMOperatorDependencies
Unexpected error:
<*errors.withStack | 0xc002889938>:
failed to get vm-operator StorageClass test-storageclass: no kind is registered for the type v1.StorageClass in scheme "pkg/runtime/scheme.go:100"
{
error: <*errors.withMessage | 0xc000461220>{
cause: <*runtime.notRegisteredErr | 0xc002a88de0>{
schemeName: "pkg/runtime/scheme.go:100",
gvk: {Group: "", Version: "", Kind: ""},
target: nil,
t: <*reflect.rtype | 0x2f070a0>{
t: {Size_: 0x168, PtrBytes: 0x158, Hash: 4276623934, TFlag: 7, Align_: 8, FieldAlign_: 8, Kind_: 25, Equal: nil, GCData: 85, Str: 252249, PtrToThis: 10592864},
},
},
msg: "failed to get vm-operator StorageClass test-storageclass",
},
stack: [0x25997df, 0xf2ad12, 0xf2ab6d, 0xf2b025, 0x2592548, 0x2602105, 0x23de878, 0xc27db3, 0xc3bf6d, 0x47b361],
}
occurred[0m
[38;5;9mIn [1m[It][0m[38;5;9m at: [1m/home/prow/go/src/sigs.k8s.io/cluster-api-provider-vsphere/test/e2e/e2e_setup_test.go:331[0m [38;5;243m@ 06/26/24 08:21:09.139[0m
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main
We need
- https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/1feaf6a9572b97e003990f4de52112d2a97f7367/test/e2e/data/infrastructure-vsphere-govmomi/v1.10 but for supervisor
- entries like https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/1feaf6a9572b97e003990f4de52112d2a97f7367/Makefile#L402-L403
- and reference the created files in the
vsphere.yaml
Weird error for govmomi, maybe this was due to their maintenance.
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
Could have been related to NSX-T maintenance
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
was related to thumbprint change to sha256, changed back to sha1
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
LGTM label has been added.
We should probably also squash the commits when we rebase. I think merge commits in PRs were not good (I don't remember the reason)
@sbueringer: The following commands are available to trigger required jobs:
/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main/test pull-cluster-api-provider-vsphere-e2e-govmomi-main/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main/test pull-cluster-api-provider-vsphere-e2e-supervisor-main/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main/test pull-cluster-api-provider-vsphere-test-main/test pull-cluster-api-provider-vsphere-verify-main
The following commands are available to trigger optional jobs:
/test pull-cluster-api-provider-vsphere-apidiff-main/test pull-cluster-api-provider-vsphere-janitor-main
Use /test all to run the following jobs that were automatically triggered:
pull-cluster-api-provider-vsphere-apidiff-mainpull-cluster-api-provider-vsphere-e2e-govmomi-blocking-mainpull-cluster-api-provider-vsphere-e2e-supervisor-blocking-mainpull-cluster-api-provider-vsphere-test-mainpull-cluster-api-provider-vsphere-verify-main
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment