cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

🌱 add `Go` directive check as `Makefile` target

Open adityabhatia opened this issue 1 year ago • 4 comments
trafficstars

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #2810

adityabhatia avatar May 14 '24 19:05 adityabhatia

Wondering if we should differ from the CAPI version of this script or if the improvements here should get also added to the one used in CAPI

Let's improve it here and then as a follow-up sync back to CAPI

sbueringer avatar May 16 '24 10:05 sbueringer

Thx!

/lgtm

/assign @chrischdi

sbueringer avatar May 17 '24 11:05 sbueringer

LGTM label has been added.

Git tree hash: 590d5dd909783ca9ca19b3e83a9e8eea7b270469

k8s-ci-robot avatar May 17 '24 11:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 21 '24 10:05 k8s-ci-robot