cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

🌱 Drop redundant e2e tests

Open sbueringer opened this issue 1 year ago • 2 comments
trafficstars

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it: This PR drops the following tests because they are just testing core CAPI features and we don't have to run them in CAPV as well:

  • capv-e2e.[It] ClusterAPI Machine Deployment Tests Running the MachineDeployment rollout spec Should successfully upgrade Machines upon changes in relevant MachineDeployment fields
  • capv-e2e.[It] When testing MachineDeployment scale out/in Should successfully scale a MachineDeployment up and down upon changes to the MachineDeployment replica count
  • capv-e2e.[It] When testing node drain timeout A node should be forcefully removed if it cannot be drained in time

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

sbueringer avatar May 13 '24 16:05 sbueringer

/assign @chrischdi @fabriziopandini

sbueringer avatar May 13 '24 16:05 sbueringer

LGTM label has been added.

Git tree hash: f8c879dfda67fc1b0e577df77f34042e30ceac82

k8s-ci-robot avatar May 14 '24 11:05 k8s-ci-robot

Nice! /lgtm /approve

fabriziopandini avatar May 14 '24 15:05 fabriziopandini

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 14 '24 15:05 k8s-ci-robot