cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
🌱 Remove keep alive feature
What this PR does / why we need it: Keep alive is deprecated in current release and will be removed in future release. Please find more details in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/2896
- Remove keep alive feature for CAPV govmomi mode
- Remove keep alive feature for CAPV supervisor mode e2e test
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):
Part of #2945
Thx! /lgtm /assign @chrischdi
LGTM label has been added.
/test ?
@sbueringer: The following commands are available to trigger required jobs:
-
/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
-
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
-
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
-
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
-
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-29-1-30-main
-
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
-
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
-
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
-
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
-
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-29-1-30-main
-
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
-
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
-
/test pull-cluster-api-provider-vsphere-test-main
-
/test pull-cluster-api-provider-vsphere-verify-main
The following commands are available to trigger optional jobs:
-
/test pull-cluster-api-provider-vsphere-apidiff-main
Use /test all
to run the following jobs that were automatically triggered:
-
pull-cluster-api-provider-vsphere-apidiff-main
-
pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
-
pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
-
pull-cluster-api-provider-vsphere-test-main
-
pull-cluster-api-provider-vsphere-verify-main
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-29-1-30-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-29-1-30-main /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
@chrischdi thanks for catching it! Fixed.
Looks like the linter found an (minor) issue
/lgtm
/assign @chrischdi
Thx!
LGTM label has been added.
@zhanggbj: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-cluster-api-provider-vsphere-apidiff-main | a696b5bd1299b9e33f106d39eb1bb61ef82a938a | link | false | /test pull-cluster-api-provider-vsphere-apidiff-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chrischdi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [chrischdi]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment