cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

🌱 Allow to set custom label for PCI device

Open maximsnezhkov opened this issue 1 year ago • 5 comments

What this PR does / why we need it: Allow to set custom label for PCI devices.

Which issue(s) this PR fixes: Fixes #2470

maximsnezhkov avatar Oct 29 '23 15:10 maximsnezhkov

Hi @maximsnezhkov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 29 '23 15:10 k8s-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.59%. Comparing base (47e62f1) to head (6f47186). Report is 543 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2471      +/-   ##
==========================================
- Coverage   63.60%   63.59%   -0.01%     
==========================================
  Files         123      123              
  Lines        8773     8774       +1     
==========================================
  Hits         5580     5580              
- Misses       2777     2778       +1     
  Partials      416      416              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 30 '23 10:10 codecov[bot]

/retest

killianmuldoon avatar Oct 30 '23 10:10 killianmuldoon

@maximsnezhkov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-e2e-blocking-main 6f4718626ac6064ca98eb95195b62ca1c5e273cc link true /test pull-cluster-api-provider-vsphere-e2e-blocking-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jan 26 '24 18:01 k8s-ci-robot

Hm, what is the current state of this PR?

sbueringer avatar Apr 09 '24 12:04 sbueringer

LGTM label has been added.

Git tree hash: 66e464ac46d16c80d5c3268e1677738b3a24d641

k8s-ci-robot avatar Apr 09 '24 12:04 k8s-ci-robot

@maximsnezhkov Apologies for the delay

/approve

sbueringer avatar Apr 09 '24 12:04 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 09 '24 12:04 k8s-ci-robot