cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
🌱 Setup separate context for test files to avoid flaky errors
What this PR does / why we need it: Setup separate context for test files under /controllers instead of using the test-package context, this is to avoid flaky errors we found in CI.
Please find more details in #2295
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2295
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.34%. Comparing base (
a4eef1b) to head (08f5135). Report is 543 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2462 +/- ##
==========================================
- Coverage 63.63% 63.34% -0.29%
==========================================
Files 122 122
Lines 8753 8753
==========================================
- Hits 5570 5545 -25
- Misses 2773 2791 +18
- Partials 410 417 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Related to #2506 (I think)
Let's hold this work until we are sure about why it happened in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/compare/269023424b03a8c029ad95b605f0b6bf9431f9a3..b00e9811fd246af7a9e03676d9577b8ef56106d0 and if this would bring a benefit at all
/hold
@zhanggbj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-vsphere-e2e-blocking-main | 08f51358b87be7376e57bbf1f8ec2fba75b49fdb | link | true | /test pull-cluster-api-provider-vsphere-e2e-blocking-main |
| pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main | 08f51358b87be7376e57bbf1f8ec2fba75b49fdb | link | true | /test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main |
| pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main | 08f51358b87be7376e57bbf1f8ec2fba75b49fdb | link | true | /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
I think we don't need this anymore.
/close
@chrischdi: Closed this PR.
In response to this:
I think we don't need this anymore.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.