Typo in CAPV controller manager ClusterRole label selector

[srm09]

trafficstars

/kind bug

What steps did you take and what happened: I was looking at the aggregated role that CAPV uses for the controller manager. It specifically uses that to allow provider service account controller to be able to create roles/role bindings with extra RBAC permissions that the ones granted to the manager for normal operation. It uses a ClusterRole with label selector capv.infrastucture.cluster.x-k8s.io/aggregate-to-manager: "true". As you can see there is a typo in infrastructure.

What did you expect to happen: The label selector should not have the typo. I'd propose for it to be replaced with a newer label selector capv.infrastructure.cluster.x-k8s.io/aggregate-to-manager: "true" (without the typo) and the label selector with the typo to be deprecated and eventually phased out in favor of the newer one.

Anything else you would like to add: For a few releases, CAPV should support both and release note the new label selector as well as the deprecation of the existing one with the date probable schedule of the deletion.

Environment:

• Cluster-api-provider-vsphere version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):