cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
kubernetes-sigs
Proposal for IPAM support
What this PR does / why we need it: This PR adds a proposal for adding IPAM support in CAPV.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
Welcome @flawedmatrix!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @flawedmatrix. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Run make lint-markdown to run the markdown verifier locally and fix the issues.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: srm09, yastij
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [srm09,yastij]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Just one last thing about the name of the finalizer to protect the IP address in use, since the finalizer is being applied by CAPV we should tweak the name to something on the lines of the existing finalizers, vspherevm.infrastructure.cluster.x-k8s.io/ip-address-protection. We can discuss more on the implementation PR, this is a nit.
Thanks for all the hard work here, this looks good to go. /lgtm