cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
Maintain flavors in template directory
What this PR does / why we need it: Maintain generated flavors in the repo. This allows generating workload clusters using the --from flag of clusterctl generate which is useful during development.
This practice is used in other providers such as CAPA and CAPZ. Furthermore, it is expected that all providers publish the generated templates in the repo. From the CAPI docs:
Additionally, the provider repository SHOULD contain the following files:
- Workload cluster templates
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
None
Special notes for your reviewer: Are we running make verify-gen somewhere in the CI? If not, I think we should because this would ensure contributors don't forget to run make generate before committing.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
Maintain workload cluster templates in the CAPV repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yastij
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [yastij]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm