cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Fix markdown tables in test/e2e/README.md

Open johananl opened this issue 3 years ago • 2 comments
trafficstars

This PR fixes a few issues with markdown tables in test/e2e/README.md.

johananl avatar Aug 15 '22 09:08 johananl

Please rebase, the thumbprint was updated in the CI config which was merged in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/1595 Maybe I should move that out to an external secret as well. Will raise a PR soon.

srm09 avatar Aug 17 '22 20:08 srm09

https://github.com/kubernetes/test-infra/pull/27168 moves the thumbprint logic over to an external secret instead of pulling it from a file.

srm09 avatar Aug 17 '22 21:08 srm09

/retest

srm09 avatar Aug 18 '22 05:08 srm09

Rebased. I'm not sure if you wanted me to change anything else following the two PRs you've mentioned @srm09. This PR only fixes Markdown style, i.e. I haven't touched the vars themselves.

johananl avatar Aug 18 '22 08:08 johananl

The rebase was required to include the CI config changes, nothing else. It was needed for the e2e tests to pass. /lgtm /approve

srm09 avatar Aug 18 '22 17:08 srm09

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 18 '22 17:08 k8s-ci-robot