Updating the API types for PCI devices

[srm09]

trafficstars

/kind feature

Describe the solution you'd like CAPV 1.3.0 introduced support fort PCI devices. While re-reviewing the API types, we realized that the introduced types

type PCIDeviceSpec struct {
	// DeviceID is the device ID of a virtual machine's PCI, in integer.
	// Defaults to the eponymous property value in the template from which the
	// virtual machine is cloned.
	// +kubebuilder:validation:Required
	DeviceID *int32 `json:"deviceId,omitempty"`
	// VendorId is the vendor ID of a virtual machine's PCI, in integer.
	// Defaults to the eponymous property value in the template from which the
	// virtual machine is cloned.
	// +kubebuilder:validation:Required
	VendorID *int32 `json:"vendorId,omitempty"`
}

have not been named according to API naming conventions. For example, the deviceId field should be named deviceID and similarly vendorId should be named vendorID.

Using this issue tracks changing the variable names for these types.

Anything else you would like to add: One thing to consider would be to handle upgrades for VSphereMachine objects having PCI device definitions with the current naming conventions.

Environment:

• Cluster-api-provider-vsphere version: v1.3.x

/kind api-change /priority important-longterm

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten