:seedling: Re-enable LB network provider unit-tests

[AectannArd]

What this PR does / why we need it: It enables the unit test scenario with "DummyLBNetworkProvider" which was formally commented out.

Which issue(s) this PR fixes: Fixes #1324

Special notes for your reviewer:

Release note:

[k8s-ci-robot]

Hi @AectannArd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AectannArd]

@srm09 could you check this out, please

[AectannArd]

/assign

[AectannArd]

/cc @yastij

[srm09]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval by writing /assign @fabriziopandini in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[AectannArd]

/retest

[AectannArd]

/retest

[AectannArd]

/retest

[AectannArd]

/retest

[AectannArd]

@vrabbi @yastij Could you have a look, please?

[geetikabatra]

/ok-to-test

[srm09]

@AectannArd Can you squash the changes?

[AectannArd]

Sure. Will do in a couple of hours

[AectannArd]

/retest

[AectannArd]

vsphere_cluster_reconciler_test seems to be particularly flaky (although I did not even touch it)

------------------------------
• Failure [30.435 seconds]
VIM based VSphere ClusterReconciler
/home/prow/go/src/sigs.k8s.io/cluster-api-provider-vsphere/controllers/vspherecluster_reconciler_test.go:49
  Reconcile delete
  /home/prow/go/src/sigs.k8s.io/cluster-api-provider-vsphere/controllers/vspherecluster_reconciler_test.go:247
    should remove legacy finalizer if present during the cluster deletion [It]
    /home/prow/go/src/sigs.k8s.io/cluster-api-provider-vsphere/controllers/vspherecluster_reconciler_test.go:256
    Timed out after 30.001s.
              
    Expected
        <bool>: false
    to be true
    /home/prow/go/src/sigs.k8s.io/cluster-api-provider-vsphere/controllers/vspherecluster_reconciler_test.go:355

[AectannArd]

@srm09 squashing done successfully

[srm09]

vsphere_cluster_reconciler_test seems to be particularly flaky Yes it is on my list to fix it, I have observed those flakes myself.

[srm09]

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [srm09]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment