cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
kubernetes-sigs
:seedling: Added PR message verification with kubebuilder-release-tools
What this PR does / why we need it: It adds instrumentation for verifying PR with kubebuilder-release-tools
Which issue(s) this PR fixes: Fixes #1548
Special notes for your reviewer: Brings dependency on kubebuilder-release-tools No images are affected
Release note:
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: AectannArd / name: Grey (48bb8ac965ef444507aaefe9b443f3a90c513919, 35585c0d8e1820d87bd3327fb6362848b993bdba)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @AectannArd!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @AectannArd. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I've fixed the aforementioned issues. A small notice should be that if your are planning to use release-note generation then the branching structure of the repo will have to be changed 'cause the note generation tool works only with hard-coded patterns which seem to be not overrideable.
@ditsuke thanks, let's hope that @srm09 will find a moment to check it in the nearest future
@AectannArd Can you suggest what are the changes required for the repo? I'd like to close loop on this one in the next release, if possible and if the changes to the repo structure don't have far reaching effects.
@srm09 All the file changes for the feature to work are supplied in this PR. They bring 2 things:
- a github-action for controlling the MR-titles (it will demand that all the following PRs have a classifier-prefix, otherwise the MR will fail to build
- a command
make generate-release-notesfor you to call while preparing for the release which will output the groupped textblocks of release changeset
The worst thing that could happen is that all the PRs open at the moment will have to fix their title.
@srm09 can we go ahead and merge or should we wait for @vrabbi 's approval?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: srm09
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [srm09]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment