cluster-api-provider-vsphere
cluster-api-provider-vsphere copied to clipboard
kubernetes-sigs
Add storagePolicyName and datastore at disk level
What this PR does / why we need it:
For control plane nodes, we need etcd to be using a faster storage policy.
Mid-term, other fields could be added to the disks field.
Which issue(s) this PR fixes: Fixes #1538
Special notes for your reviewer:
- This changes the Spec, in a backward compatible way. But deprecated fields should probably be removed in beta2.
- Maybe this should be
datastores(plural)? This adds some logic, but prepare for #1227.
Release note:
Allow to set storagePolicyName and datastore at disk level.
The format of the spec changed and diskGiB and additionalDisksGiB are now deprecated
Welcome @sathieu!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @sathieu. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign frapposelli after the PR has been reviewed.
You can assign the PR to them by writing /assign @frapposelli in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@vrabbi @yastij Please review and add ok-to-test :pray:. I've done tests on a development vSphere.
@sathieu: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I don't know if anybody is reviewing PRs here 🤔 .
Resolving conflicts takes time, so I put this PR on hold for now.
@sathieu The use case that you have mentioned around using a faster storage policy for ETCD, can it not be met by overriding the storage policy for the VSphereMachineTemplate for the Control Plane nodes?
@srm09 Using storage policy for control plane nodes will cover the etcd case (partly, because we don't necessarily need fast storage for images). But we also need having a different FTT on some disk to use rook-ceph.
Anyway, we are currently reconsidering cluster-api because of it's need of access to the vsphere API from the workload clusters (see https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/924#issuecomment-1123803887).
@sathieu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-vsphere-test | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-test |
| pull-cluster-api-provider-vsphere-integration-test | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-integration-test |
| pull-cluster-api-provider-vsphere-verify-lint | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-verify-lint |
| pull-cluster-api-provider-vsphere-e2e | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-e2e |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@sathieu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-vsphere-test | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-test |
| pull-cluster-api-provider-vsphere-integration-test | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-integration-test |
| pull-cluster-api-provider-vsphere-verify-lint | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-verify-lint |
| pull-cluster-api-provider-vsphere-e2e | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-e2e |
| pull-cluster-api-provider-vsphere-verify-gen | deddc7e8aeee4b28138dd6a7878e96b25d311905 | link | true | /test pull-cluster-api-provider-vsphere-verify-gen |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@srm09: Closed this PR.
In response to this:
/close Closing due to inactivity
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.