cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add Calico flag to generate CNI resources for cluster templates

Open srm09 opened this issue 3 years ago • 6 comments

/kind feature

Describe the solution you'd like Currently, the cluster templates generated by CAPV do not deploy any CNI resources by default. This becomes a manual step when using the template to deploy clusters. Since, CAPV does not prescribe any particular CNI, but uses Calico in its e2e tests, it would make sense to include an extra flag during template generation --calico (just an example) to include the Calico resources as part of the CRS which is used to deploy CPI/CSI.

Anything else you would like to add: As a first step, we can try to include this with the vip flavor and then extend it over to other flavors too.

Environment:

  • Cluster-api-provider-vsphere version: tip of main branch
  • Kubernetes version: (use kubectl version): n/a
  • OS (e.g. from /etc/os-release): n/a

/help /good-first-issue

srm09 avatar Jan 28 '22 20:01 srm09

@srm09: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature

Describe the solution you'd like Currently, the cluster templates generated by CAPV do not deploy any CNI resources by default. This becomes a manual step when using the template to deploy clusters. Since, CAPV does not prescribe any particular CNI, but uses Calico in its e2e tests, it would make sense to include an extra flag during template generation --calico (just an example) to include the Calico resources as part of the CRS which is used to deploy CPI/CSI.

Anything else you would like to add: As a first step, we can try to include this with the vip flavor and then extend it over to other flavors too.

Environment:

  • Cluster-api-provider-vsphere version: tip of main branch
  • Kubernetes version: (use kubectl version): n/a
  • OS (e.g. from /etc/os-release): n/a

/help /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 28 '22 20:01 k8s-ci-robot

/assign @scdubey

scdubey avatar Jan 28 '22 21:01 scdubey

/unassign

scdubey avatar May 08 '22 22:05 scdubey

/help /good-first-issue

srm09 avatar May 09 '22 01:05 srm09

/assign

geetikabatra avatar Jul 14 '22 15:07 geetikabatra

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 12 '22 16:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 11 '22 22:11 k8s-triage-robot

/close

If this feature is still needed by someone feel free to reopen :-)

The CAPI quickstart includes deploying a CNI separately.

chrischdi avatar Aug 31 '23 17:08 chrischdi

@chrischdi: Closing this issue.

In response to this:

/close

If this feature is still needed by someone feel free to reopen :-)

The CAPI quickstart includes deploying a CNI separately.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 31 '23 17:08 k8s-ci-robot