cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

support to filter vspherecluster vspheredeploymentzone by annotation

Open sadysnaat opened this issue 3 years ago • 5 comments

/kind feature

vspheredeploymentzones are clusterscoped resources a vspherecluster picks up all vspheredeploymentzones that have same server as the vspherecluster

now we have a use case where we launch other vsphere clusters from a vsphere cluster which is created by capi so that cluster has its own vspheredeploymentzone and picks up other cluster’s vspheredeploymentzone too should

Describe the solution you'd like we support some kind of filtering by annotations to prevent clusters from picking up vspheredeploymentzone just by matching servers

we currently have an implementation which selects the deploymentzone using an annotation vsphere.infrastructure.cluster.x-k8s.io/adopt-deploymentzone: "dz1,dz2"

on vspherecluster so if there are dz1, dz2 and dz3 are present vpsherecluster will only select dz1 and dz2 not dz3

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

sadysnaat avatar Dec 09 '21 14:12 sadysnaat

/assign @sadysnaat

sadysnaat avatar Dec 09 '21 14:12 sadysnaat

cc: @srm09

gab-satchi avatar Dec 09 '21 18:12 gab-satchi

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 09 '22 19:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 08 '22 19:04 k8s-triage-robot

/remove-lifecycle rotten /lifecycle frozen

srm09 avatar Apr 20 '22 17:04 srm09

/close

CAPV now has a failureDomainSelector which could get used instead. Feel free to reopen and add more context if needed.

chrischdi avatar Aug 17 '23 17:08 chrischdi

@chrischdi: Closing this issue.

In response to this:

/close

CAPV now has a failureDomainSelector which could get used instead. Feel free to reopen and add more context if needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 17 '23 17:08 k8s-ci-robot