cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard
verified publisher icon kubernetes-sigs

🌱 Bump golanci-lint to v2.7.2

Open lentzi90 opened this issue 1 week ago • 4 comments

What this PR does / why we need it:

Golanci-lint is updated to the newest version.

Two new linting errors appeared:

  1. The errors package conflicts with standard library package.
  2. The shared package name is considered "meaningless".

I have renamed these packages to capoerrors and e2eshared.

This is a backport of #2894.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [x] squashed commits
  • if necessary:
    • [ ] includes documentation
    • [ ] adds unit tests

lentzi90 avatar Dec 11 '25 11:12 lentzi90

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign emilienm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 11 '25 11:12 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit fb87e6109d0a84e42c6aead309732835628c4e65
Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/693aa9236ed5090008ac49d9
Deploy Preview https://deploy-preview-2902--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Dec 11 '25 11:12 netlify[bot]

/hold I am not sure we should really do this for release branches. The golangci-lint updated workflow should not even run against PRs. Fixed for release-0.13 in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2904

lentzi90 avatar Dec 12 '25 07:12 lentzi90

I don't see any harm to have at least in release 0.13. So lgtm from my side /lgtm

smoshiur1237 avatar Dec 12 '25 08:12 smoshiur1237