cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard

:sparkles: Add support for autoscaling to/from 0

Open nikParasyr opened this issue 2 weeks ago • 6 comments

What this PR does / why we need it: Add support for autoscaling to/from 0. To do this:

  • Follow the contract for doing this as documented here
  • Add a new controller to patch OpenStackMachineTemplate.Status accordingly
  • Add the feature behind a feature flag

Which issue(s) this PR fixes: Fixes #1328

Special notes for your reviewer: I'm currently not adding support for:

  1. Architecture info: Could not find a standardized flavor extra_spec for this one. There are some traits/resource specific ones but they seem to be for when ironic is used. Images can have an architecture attribute but im not sure whether this should be used => I'd prefer to leave this out of this PR and see if users need/require this.
  2. GPU info: Again couldn't find the standardized extra_spec for this. I would also need to check what type of info autoscaler expects ( just vendor info or even gpu model info etc ) => I'd prefer to leave this out of this PR and see if users need/require this.

TODOs:

  • [ ] squashed commits
  • if necessary:
    • [x] includes documentation
    • [X] adds unit tests
    • [X] adds e2e tests

/hold

nikParasyr avatar Dec 04 '25 12:12 nikParasyr

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 0986a373625935ddcbc116eb3120159d62167626
Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/694565eba0247300085f70cb
Deploy Preview https://deploy-preview-2880--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Dec 04 '25 12:12 netlify[bot]

Hi @nikParasyr. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 04 '25 12:12 k8s-ci-robot

/ok-to-test

bnallapeta avatar Dec 05 '25 01:12 bnallapeta

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mandre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 17 '25 14:12 k8s-ci-robot

/test pull-cluster-api-provider-openstack-e2e-test

nikParasyr avatar Dec 19 '25 11:12 nikParasyr

@nikParasyr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 0986a373625935ddcbc116eb3120159d62167626 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Dec 19 '25 15:12 k8s-ci-robot