📖 proposal: add support for defining trunk subports
What this PR does / why we need it: Proposal doc for #2861
/hold
Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
| Name | Link |
|---|---|
| Latest commit | 83fc91f05f4fb93b25f607742e3fe85b28edd0ee |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6926c48deb91d7000758c60d |
| Deploy Preview | https://deploy-preview-2862--kubernetes-sigs-cluster-api-openstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/cc @lentzi90
@lentzi90 do you have some time to take a look at this?
Sorry for the delay! I don't have any immediate concerns. It looks like a useful feature. However, I think we should coordinate this with ORC so we don't end up making things unnecessarily painful later. There is already a Port resource in ORC, but I don't think it has Trunk support yet.
Hi @lentzi90! ORC already has a work still in progress to add a new Trunk controller on this PR. Since it is still in progress, I believe it can be aligned with CAPO interests.
(sorry for meddling)