✨ Add trunk subports support for OpenStackMachine ports

[bnallapeta]

What this implements

This adds the ability to specify subports when creating trunk ports. Users can now define VLAN subports that will be attached to the trunk when the port is created.

Example usage:

  ports:
  - network: 
       filter:
         name: foo_vlan_300
     trunk: true 
     subports:
     - network:
          filter:
            name: bar_vlan_301
        segmentationID: 301
        segmentationType: "vlan"

• Added SubportOpts and ResolvedSubportSpec types to API
• Since sub-ports and ports are essentially the same entities CommonPortOpts and CommonResolvedPortSpec types were introduced as a basis for regular ports and trunk subports
• Added SubPortStatus to keep track of ports which are associated with trunk
• Introduced separate method for adding supports to trunk
• Added AddSubports method to NetworkClient interface
• Added validation to ensure subports require trunk enabled
• Updated port normalization to resolve subports

Testing done

• unit test
• tests on real env

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	80f07c310292a51e6c99feba7f3733f22d0a3c8b
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68f0a4fe8e9f350008ddb5a3
😎 Deploy Preview	https://deploy-preview-2789--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @bnallapeta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lentzi90]

/ok-to-test This is so large that I think we should at least have an issue, perhaps even a proposal to discuss and design it first

[k8s-ci-robot]

@bnallapeta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-openstack-test	80f07c310292a51e6c99feba7f3733f22d0a3c8b	link	true	/test pull-cluster-api-provider-openstack-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.