cluster-api-provider-openstack 🌱 ORC: Generate common parts of resource API

🌱 ORC: Generate common parts of resource API

Open mdbooth opened this issue 1 year ago • 2 comments

Adds a very simple code generator which simply uses a go template to generate the common parts of an ORC resource API.

My preference was to do this with generics, but for now this breaks controller-tools: https://github.com/kubernetes-sigs/controller-tools/issues/844

/hold

Oct 22 '24 10:10 mdbooth

Name	Link
Latest commit	e4e85c39ee44468776a0ab349aa3fbe7d43b2287
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/671f60db3260220008a9c7e6
Deploy Preview	https://deploy-preview-2203--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Oct 22 '24 10:10 netlify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Oct 24 '24 08:10 k8s-ci-robot

/lgtm

Oct 28 '24 09:10 pierreprinetti

Just discovered a templating bug in this PR while adding subnet: the spec ends up on the same line as the previous validation. Will fix.

Oct 28 '24 09:10 mdbooth

/hold cancel

Oct 28 '24 12:10 mdbooth

/lgtm

Oct 28 '24 12:10 EmilienM