cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

[Release v0.9] Cannot delete a server in ERROR state which has trunk ports

Open mdbooth opened this issue 1 year ago • 0 comments

/kind bug

In v0.9, if the instance is in error state we call GarbageCollectErrorInstancesPort, which doesn't support trunk ports: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/4042fc614c8b06be42032b2c94a970670f6288b7/pkg/cloud/services/compute/instance.go#L677-L687

This isn't the case on main, which has a completely different code path for this. On main we always adopt ports, and will always clean them up, along with trunks.

We will also panic if the port doesn't exist because we don't check for an empty port list.

mdbooth avatar May 17 '24 14:05 mdbooth