cluster-api-provider-openstack
cluster-api-provider-openstack copied to clipboard
✨ New CRD + controller for OpenStackServer (v1alpha1)
What this PR does / why we need it:
A new CRD and controller which will manage the OpenStack servers in the cluster.
#2020 #2021
TODOs:
- [x]
OpenStackServerAPI &&make generate - [x] openstackserver webook (MVP)
- [x] openstackserver_controller: create/delete/adopt instances & ports (MVP)
- [x] Migrating Bastion to use the new controller (MVP)
- [x] Migrating OpenStackMachine to the new controller (MVP)
- [x] Stop storing the bastion spec hash into the
OpenStackClusterannotations and watch for changes in Bastion spec, where any change would trigger abastionDelete. - [x] Switch
UserDataas a ref - [x] adds unit tests
- [x] includes documentation
- [ ] squashed commits
Future work that can happen outside this PR:
- Stop populating server related status fields for both
OpenStackClusterandOpenStackMachineobjects, since they now live inOpenStackServer. The fields will be removed for a potentialv1. - Optimize
SetupWithManagerwhen watching forOpenStackServer, since we are only interested in certain state transition: when the server is deleted, and when the server is ready. For that we probably want to write Predicate functions.
Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
| Name | Link |
|---|---|
| Latest commit | fb3779cdb1d72a02f03ddf5eaa21d96c912a2cf5 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66990e7fdf2bc80008aef505 |
| Deploy Preview | https://deploy-preview-2067--kubernetes-sigs-cluster-api-openstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
maybe I'm a bit out of context but why do we move to OpenStackServer instead of OpenStackMachine ?
maybe I'm a bit out of context but why do we move to OpenStackServer instead of OpenStackMachine ?
Hey @mnaser, have a look at https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2021/ and let us know what you think.
Oh, very interesting. Makes a lot of sense. Thanks @EmilienM
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
e2e jobs passed, I want to see if they pass again a few times to ensure I didn't miss any race.
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
Two successful CI jobs in a row. Let's try a third and stop the rechecks, letting others to review.
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
Just a (clean) rebase on main.
/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test for sanity, this is ready to merge
/lgtm /approve
Let's do this!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mdbooth]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment