cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard

🐛 Add terminal failure for lb client init

Open EmilienM opened this issue 1 year ago • 5 comments

Originally submitted via https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1960 by @Goend.

What this PR does / why we need it: After loadBalancerService client init failed,we should give failed message to openstackcluster status.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1950

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [X] squashed commits
  • if necessary:
    • [X] includes documentation
    • [X] adds unit tests

/hold

EmilienM avatar Apr 24 '24 14:04 EmilienM

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 24 '24 14:04 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 95502d6a9f3e274394a6ddd717f468fea465636f
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6629162a35f55b00086931de
Deploy Preview https://deploy-preview-2036--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 24 '24 14:04 netlify[bot]

I've basically moved the PR and fixed the tests. I've not changed much from the original PR except a couple of comments that I put in the first PR.

EmilienM avatar Apr 24 '24 14:04 EmilienM

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-test 95502d6a9f3e274394a6ddd717f468fea465636f link true /test pull-cluster-api-provider-openstack-test
pull-cluster-api-provider-openstack-e2e-test 95502d6a9f3e274394a6ddd717f468fea465636f link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 24 '24 15:04 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 08 '24 00:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 06 '24 01:09 k8s-triage-robot

@EmilienM The test case seems to have not been completely modified to cause this error, especially in the v1alphav6 version

Goend avatar Sep 06 '24 06:09 Goend

I don't plan to work on that in the near future, so I'll close it for now.

EmilienM avatar Sep 26 '24 15:09 EmilienM