cluster-api-provider-openstack
cluster-api-provider-openstack copied to clipboard
🐛 Add terminal failure for lb client init
Originally submitted via https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1960 by @Goend.
What this PR does / why we need it: After loadBalancerService client init failed,we should give failed message to openstackcluster status.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1950
Special notes for your reviewer:
- Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
- [X] squashed commits
- if necessary:
- [X] includes documentation
- [X] adds unit tests
/hold
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
| Name | Link |
|---|---|
| Latest commit | 95502d6a9f3e274394a6ddd717f468fea465636f |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6629162a35f55b00086931de |
| Deploy Preview | https://deploy-preview-2036--kubernetes-sigs-cluster-api-openstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I've basically moved the PR and fixed the tests. I've not changed much from the original PR except a couple of comments that I put in the first PR.
@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-openstack-test | 95502d6a9f3e274394a6ddd717f468fea465636f | link | true | /test pull-cluster-api-provider-openstack-test |
| pull-cluster-api-provider-openstack-e2e-test | 95502d6a9f3e274394a6ddd717f468fea465636f | link | true | /test pull-cluster-api-provider-openstack-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@EmilienM The test case seems to have not been completely modified to cause this error, especially in the v1alphav6 version
I don't plan to work on that in the near future, so I'll close it for now.