cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard

Occasional flake stopping manager in apivalidations envtest

Open mdbooth opened this issue 1 year ago • 2 comments

/kind bug

An example: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/2012/pull-cluster-api-provider-openstack-test/1780643147475324928/build-log.txt

  [1mSTEP:[0m Tearing down manager [38;5;243m@ 04/17/24 17:20:20.381[0m
  "level"=0 "msg"="Stopping and waiting for non leader election runnables"
  "level"=0 "msg"="Stopping and waiting for leader election runnables"
  "level"=0 "msg"="Stopping and waiting for caches"
  "level"=0 "msg"="Stopping and waiting for webhooks"
  [38;5;9m[FAILED][0m in [DeferCleanup (Suite)] - /home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/apivalidations/suite_test.go:152 [38;5;243m@ 04/17/24 17:20:25.384[0m
  [38;5;243m<< Timeline[0m

  [38;5;9m[FAILED] Timed out after 5.002s.
  Manager should stop
  Expected
      <chan struct {} | len:0, cap:0>: 0xc0008554a0
  to be closed[0m
  [38;5;9mIn [1m[DeferCleanup (Suite)][0m[38;5;9m at: [1m/home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/apivalidations/suite_test.go:152[0m [38;5;243m@ 04/17/24 17:20:25.384[0m
[38;5;243m------------------------------[0m

The default timeout is 1 second. I bumped it to 5, but it seems that is not enough. I doubt this is an actual code problem, but I wouldn't 100% rule it out.

mdbooth avatar Apr 18 '24 08:04 mdbooth

@JoelSpeed I think this is in code I copied from you. I don't suppose you've seen this tearing down envtests, have you?

mdbooth avatar Apr 18 '24 09:04 mdbooth

Have never seen issues with tearing down envtest before no, this is new to me

JoelSpeed avatar Apr 18 '24 09:04 JoelSpeed

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 17 '24 09:07 k8s-triage-robot

@mdbooth still seeing it? not myself recently

EmilienM avatar Jul 17 '24 11:07 EmilienM

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 16 '24 11:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Sep 15 '24 12:09 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 15 '24 12:09 k8s-ci-robot